search

hasura / go-graphql-client

Package graphql provides a GraphQL client implementation.
MIT License
396 stars 91 forks source link

Remove canonical/vanity import path #42

Closed RangelReale closed 2 years ago

RangelReale commented 2 years ago

Because of the comment after the package name in doc.go, the library expects to be imported as github.com/shurcooL/graphql and will not compile when imported as github.com/hasura/go-graphql-client, at least when using vendoring.

package graphql // import "github.com/shurcooL/graphql"

this is the error message I get

code in directory /workspace/src/entrypoint/vendor/github.com/hasura/go-graphql-client expects import "github.com/shurcooL/graphql"

I don't think this is the intention of this fork, so this probably should be removed.

Here is documentation about Go vanity import.

hgiasac commented 2 years ago

closed by favor of https://github.com/hasura/go-graphql-client/pull/44. Can you update the version to v0.8.0 to confirm, thanks