hasura / graphql-engine

Blazing fast, instant realtime GraphQL APIs on your DB with fine grained access control, also trigger webhooks on database events.
https://hasura.io
Apache License 2.0
31.18k stars 2.76k forks source link

Can not parse OpenAPI 3 specification for Actions #10520

Open RaphaelBossek opened 2 months ago

RaphaelBossek commented 2 months ago

Version Information

Server Version: 2.43.0 CLI Version (for CLI related issue):

Environment

Docker Image: https://hub.docker.com/r/hasura/graphql-engine

What is the current behaviour?

$ref for parameters is not supported if you test the https://github.com/RaphaelBossek/jira-server-edition-openAPIv3

With the Atlassian V10 swagger JSON file, the error is "Invalid spec: Connot read properties of undefined (reading 'x-graphql-type-name')"

With https://the-guild.dev/graphql/mesh it just works.

What is the expected behaviour?

No error messages. No complains importing OpenAPI specifications.

How to reproduce the issue?

OpenAPI spec is not supported for following examples:

Screenshots or Screencast

No screenshot.

Please provide any traces or logs that could help here.

No trace files.

Any possible solutions/workarounds you're aware of?

No known workarround exist.

Keywords

openapi actions parser

manasag commented 2 months ago

Hi @RaphaelBossek, I tried with https://raw.githubusercontent.com/RaphaelBossek/jira-server-edition-openAPIv3/main/jira-server-openapi3.yaml I see this validation error: Validation failed. /paths/rest/api/2/component/{id}/get is missing path parameter(s) for {id}. But I do see that the action is being created fine despite the error. Other actions with $ref parameters are also being suggested correctly. Possible there some issue with the error reporting. Can you import all suggested actions and see if they work fine.

image
RaphaelBossek commented 2 months ago

The error reporting ist annoying and missleading, but the query works.

Varun-Choudhary commented 1 month ago

Hi @RaphaelBossek,

Thank you for bringing this issue to our attention. It's great to hear that your query is working and you're unblocked. We’ll make sure to address the error reporting as well.