search

hasura / graphql-engine

Blazing fast, instant realtime GraphQL APIs on your DB with fine grained access control, also trigger webhooks on database events.
https://hasura.io
Apache License 2.0
31.16k stars 2.76k forks source link

Disable pre-release/update notifications through an environment variable #4096

Open jflambert opened 4 years ago

jflambert commented 4 years ago

I want to be able to immediately "opt-out" (as it's called in 1.1.0) from pre-release notifications, as well as any upgrade notification, through an environment variable similar to HASURA_GRAPHQL_ENABLE_TELEMETRY. Basically I don't want to see the popups in the console.

I don't think one exists.

rikinsk commented 4 years ago

This can be solved in 2 ways:

The console can allow users to opt-out of all notifications. The notification will be shown once after which it wont be shown again for that db instance.

The server can take an ENV variable as suggested here and pass it to the console. The notification will never be shown.

Leaving this issue open for the server based solution. Created #4165 for the console only solution

jflambert commented 4 years ago

@rikinsk I'd really prefer an env var ;) but thanks

jflambert commented 4 years ago

I'm waiting for confirmation from a team mate but I was told that Hasura will crash hard when it runs in an offline environment -- because it tries to contact github.com to check for an update?

Which makes this issue even more important to fix IMHO.