Allow database config to be set via env var

hasura / graphql-engine

Blazing fast, instant realtime GraphQL APIs on your DB with fine grained access control, also trigger webhooks on database events.

https://hasura.io

Apache License 2.0

31.08k stars 2.77k forks source link

Open whollacsek opened 3 years ago

whollacsek commented 3 years ago

Similar to how database connection string can be set with from_env: HASURA_GRAPHQL_DATABASE_URL in databases.yaml, we should be able to set

max_connections:
  from_env: HASURA_GRAPHQL_PG_CONNECTIONS

happyhunter7 commented 1 year ago

@rikinsk Any news on this? I think a lot of peoples are waiting for it

It makes life hard to manage staging/prod etc without env vars I know it is already implemented for

 database_url:
        from_env: HASURA_GRAPHQL_DATABASE_URL

Isn't that just a matter of copy-paste the logic, for this parameter too

dameleney commented 1 year ago

@whollacsek What database are you using and need this supported for? ... Postgres?

whollacsek commented 1 year ago

Yes Postgres