MSSQL Permissions `allow_aggregations` - Githubissues

hasura / graphql-engine

Blazing fast, instant realtime GraphQL APIs on your DB with fine grained access control, also trigger webhooks on database events.

https://hasura.io

Apache License 2.0

31.08k stars 2.76k forks source link

MSSQL Permissions `allow_aggregations` #7734

Open rechenberger opened 2 years ago

rechenberger commented 2 years ago

Version Information

Both: v2.0.10-cloud.1 v2.0.7

Server Version: CLI Version (for CLI related issue): 2.0.9

Environment

Cloud + Docker

What is the expected behaviour?

MSSQL-Database should support aggregation queries with non-admin authentication

Keywords

aggregation permissions mssql https://hasura.io/docs/latest/graphql/core/auth/authorization/permission-rules.html#aggregation-queries-permissions

What is the current behaviour?

allow_aggregations: true seem to be ignored
there is no Aggregation Permission Accordion-Tab in the Console Permission UI
aggregation queries are not in introspection (non-admin authenticated)
aggregation queries are not found in root when executing (non-admin authenticated)

How to reproduce the issue?

connect mssql, setup a table, track etc.
allow permissions for role "test" all rows all columns and allow_aggregations: true
no aggregations allowed

Screenshots or Screencast

Please provide any traces or logs that could help here.

field \"XXX_aggregate\" not found in type: 'YYY'

Any possible solutions?

Alternative 1: Allow Aggregations in MSSQL for non-admin users
Alternative 2: (maybe just allow them for everyone who as access to the default query, maybe with a ENV var?)
Alternative 3: document missing feature

Can you identify the location in the source code where the problem exists?

no

If the bug is confirmed, would you be willing to submit a PR?

unfortunately currently not

rechenberger commented 2 years ago

related: #7576