hasura / kriti-lang

A minimal JSON templating language
Apache License 2.0
56 stars 9 forks source link

Feature/defaulting operator #47

Closed solomon-b closed 2 years ago

solomon-b commented 2 years ago

This PR adds the Defaulting Operator, fixes some ambiguities in the parser, and cleans up the parser production rules significantly.

solomon-b commented 2 years ago

That would be really neat, but I don't think there is any tooling to do that out of the box. Technically the grammar.y is the spec for the language, but I made the separate BNF because it's a bit easier for me to reason about in an isolated form when modifying the language.

A simple solution would be to tag the BNF file and the grammar.y file with the Kriti version so we can keep them in sync by convention.

On Sun, Feb 6, 2022, 3:25 PM Lyndon Maydwell @.***> wrote:

@.**** commented on this pull request.

Looks great! Could it be possible to auto generate the bnf from the actual grammar to ensure that the docs are in sync?

— Reply to this email directly, view it on GitHub https://github.com/hasura/kriti-lang/pull/47#pullrequestreview-874098286, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF3ZSQ75CSULSKB5DMKSTUZ37M7ANCNFSM5NTJQGYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>