search

hasura / learn-graphql

Real world GraphQL tutorials for frontend developers with deadlines!
https://hasura.io/learn/
MIT License
1.2k stars 651 forks source link

Update link to `next-auth-hasura-adapter` npm library #770

Closed AmruthPillai closed 2 years ago

kevinsmouts commented 1 year ago

hey guys - why was the library changed in the doc? the npm package listed at the top has been created by @AmruthPillai yet the rest of the doc is still listing the old package from @skillrecordings/next-auth-hasura-adapter

In comparison the new package from Amruth has 11 weekly downloads vs 298 weekly downloads on the other. Not saying this should not have been changed but at least some mesage in the commit explaining the reasoning of changing it?

AmruthPillai commented 1 year ago

@kevinsmouts I raised this PR because the older package @skillrecordings/next-auth-hasura-adapter did not point to an existing GitHub repository (must have been deleted or made private since then). Due to the lack of a GitHub repository on the older package, it makes it difficult to raise issues on bugs/make contributions too. It also didn't work for me when I tried to use it for my own project. So I made a new adapter that works for the newer versions of Hasura and NextAuth.

It has fewer weekly downloads probably because it's not so well-known yet that there's a new package, and many projects might still be using the older one (with an older version of Hasura and NextAuth, hence it works for them), but with newer versions, it wouldn't.

kevinsmouts commented 1 year ago

sounds good, I'll go through the tutorial using the new package and create a PR to update the doc with the new package across the doc if everthing is working adequately. cheers

kevinsmouts commented 1 year ago

https://github.com/hasura/learn-graphql/pull/797