search

hasura / learn-graphql

Real world GraphQL tutorials for frontend developers with deadlines!
https://hasura.io/learn/
MIT License
1.2k stars 649 forks source link

Many attributes have unnecessary braces #78

Closed deadcoder0904 closed 5 years ago

deadcoder0904 commented 5 years ago

There are a lot of unnecessary braces for className which might be confusing for beginners.

It doesn't even have conditionals. I'd like to tackle this one.

PS: Can u label it hacktoberfest

Edit: Not only className but href, alt, src & target have a lot of unnecessary braces but it's really not needed so I'll clean that up too

deadcoder0904 commented 5 years ago

Submitted PR https://github.com/hasura/learn-graphql/pull/79

Changed a lot of className, href, alt, src, & target. Also, there was a merge conflict since I last pushed so I solved that too.

Bdw @praveenweb how many PRs should be submitted to qualify for Hasura's Hacktoberfest? I've already submitted 2 :)