Use more direct decoding for AltJ instance

hasura / pg-client-hs

A low level Haskell library to connect to postgres

Apache License 2.0

25 stars 15 forks source link

Closed danieljharvey closed 2 years ago

danieljharvey commented 2 years ago

As per https://github.com/hasura/pg-client-hs/pull/74/files#r960213856 , our recent changes to AltJ decoding parse into an Aeson Value and then onto the target value rather than going directly.

0x777 commented 2 years ago

@danieljharvey I would recommend using a small criterion benchmark to understand the impact added by introducing dropFirst.

0x777 commented 2 years ago

https://github.com/hasura/graphql-engine-mono/pull/5709 doesn't seem to improve anything so I suspect that the performance regression in #5588 would probably be because of the additional check?

danieljharvey commented 2 years ago

@0x777 - good shout - have created a ticket to track investigating this: https://github.com/hasura/graphql-engine-mono/issues/5756