Closed GMNGeoffrey closed 2 years ago
@scriptnull PTAL @imperfect-fourth does this address your use case for #23 also?
@GMNGeoffrey Thanks for the pull request! We will read through this and get back :slightly_smiling_face:
the working directory for single repo checkout is different
Ah my bad, it seems the behaviour is same
I think that the first one can be avoided by keeping both the env vars for now and maybe marking
WORKSPACE
as deprecated. What do you think?
Sure, that makes sense to me
Sorry I was out on vacation for a while. I've updated to still set the WORKSPACE variable. Note that this still isn't backward compatible because it defaults to buildkite's default checkout path instead of the custom path that was hardcoded before. I don't see a clean way to preserve backward compatibility here.
Ping on this?
@GMNGeoffrey sorry for the delay. A new release have been made(v4.0.0) with your changes. Thank you for the contribution!
This changes the plugin to use
BUILDKITE_BUILD_CHECKOUT_PATH
by default with the ability to specify another path. When only one repo is checked out, it is checked out directly at the checkout path, as in the Buildkite default checkout behavior. When multiple repos are checked out, they are each in their own subdirectory underBUILDKITE_BUILD_CHECKOUT_PATH
with names determined by their URL.I made use of this in my own project with https://github.com/google/iree/pull/8619
Fixes https://github.com/hasura/smooth-checkout-buildkite-plugin/issues/13 Fixes https://github.com/hasura/smooth-checkout-buildkite-plugin/issues/21 Fixes https://github.com/hasura/smooth-checkout-buildkite-plugin/issues/22 Fixes https://github.com/hasura/smooth-checkout-buildkite-plugin/issues/23