Dev

[sk1tt1sh]

getSAM modules added for automatic sam and system hive retrieval.

[hatRiot]

Nice PR; changes noted.

Other questions/things to consider:

• Make sure authentication is handled properly. You import checkAuth, but don't use it.
• It's very important that if this fails, we emit as much debug info as possible. Scary to think we could dump SAM/SYSTEM, but not be able to pull it down or remove it!
• Maybe change the flag simply to --[platform]-sam? Easier to type/remember.

With some work I think it would make a neat addition.

[sk1tt1sh]

I will continue adding debug info. The flag has been updated to --[platform]-sam as well. Just need to go over a couple things and I think it'll be ready.

[sk1tt1sh]

Updates as requested. Sticking with string.replace since something causes it the think its unicode for .translate and bugs it out.

[hatRiot]

Why should this module require root?

I just ran this against Tomcat 5.5 on Windows 7 and it failed to dump SAM/SYSTEM correctly. It pulled down 0 byte files.

[sk1tt1sh]

Root privs aren't necessary I suppose. The files are saved to clustered so...if there's access on that dir for non-root cool.

It will pull 0 byte files if the service is run as a user in admin that is not running TC as an admin. Same with JBoss. I will see if there's a way to get a privs level... or a "runas option" but that will probably fail if there's UAC at all turned on.

I'll clean up the string split, and debug/bold green happiness stuff today. Thanks.

[sk1tt1sh]

Pushed changes.

[hatRiot]

I'm not convinced the module is stable enough for a merge yet, but i'll be doing some testing over the weekend.

[hatRiot]

Closed as per offline discussion.