search

hatch-sh / hatch

🐣 Easy deployment of static websites to Amazon Web Services
https://hatch.sh
5 stars 0 forks source link

Support custom domains #39

Closed skovhus closed 7 years ago

skovhus commented 7 years ago

Work in progress for fixing #3... I think this PR should do the work, but need to test a bit and understand how the bucket and domain name convention. They seem to be linked in amazon, so a domain foo.com NEEDS to have a bucket foo.com.

What do you do if a bucket name that matches your domain name is taken?

mads-hartmann commented 7 years ago

That sounds funky :) I'll have a look tonight. It's awesome you're working your way through the tickets

skovhus commented 7 years ago

What do you do if a bucket name that matches your domain name is taken?

@mads-hartmann Did you have time to look into this?

mads-hartmann commented 7 years ago

Sure thing, I'll take a look, but probably won't be till the weekend :)

mads-hartmann commented 7 years ago

@skovhus Can you create a bucket named tech-conferences.net? I own that domain so I can test what happens :)

skovhus commented 7 years ago

@mads-hartmann the script fails because I don't have a route53 configuration for that domain... But I created a bucket: http://tech-conferences.net.s3-website-us-east-1.amazonaws.com

Which zone are you in?