search

hatchet-dev / hatchet-python

Hatchet Python SDK for Interacting with the Hatchet Engine
10 stars 3 forks source link

Static workflow definition without globals #68

Closed colonelpanic8 closed 1 day ago

colonelpanic8 commented 1 week ago

Fixes #67

Open to suggestions about other ways to do this, but this seems like a pretty clean way to handle things.

grutt commented 5 days ago

Hi @colonelpanic8 I'll be taking a look at this change today. Thank you for opening this PR!

colonelpanic8 commented 5 days ago

@colonelpanic8 thank you for a quality PR. I think you took a sensible approach to this refactor and I was able to to verify everything runs as expected with our examples.

I'm going to have a quick chat with @abelanger5 later this morning to sanity check that this approach fits into some planned sdk changes we have in mind, should have an update or a merge later today.

Awesome, thanks!

colonelpanic8 commented 5 days ago

@grutt I merged with main here

grutt commented 1 day ago

@colonelpanic8 cleaned up a few things here and will have this included in 0.28.1 shortly.