hatching / httpreplay

Replay HTTP and HTTPS requests from a PCAP based on TLS Master Secrets.
Other
95 stars 35 forks source link

Add and use SSLKEYLOGFILE information from mitmproxy #15

Closed LetMeR00t closed 5 years ago

LetMeR00t commented 6 years ago

This code doesn't work yet but it's only for sharing the new additions

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.4%) to 84.204% when pulling bb17b81f15556b0c21742a93d98e1b46fd84751a on LetMeR00t:patchissuecuckoo#2103 into 3074435106c2d1eb64db6a38c2e43bb3741cb4c3 on jbremer:master.

jbremer commented 6 years ago

@LetMeR00t I don't remember what your status on this was, I believe you got something working? Could you please update me / update the PRs / etc? Thanks!

LetMeR00t commented 6 years ago

Hi @jbremer, Indeed, the code is working respecting my comments concerning Cuckoo here : https://github.com/cuckoosandbox/cuckoo/pull/2104 It seems that everything using GCM will not work... Could you try on your own ? You will probably need this part : https://github.com/cuckoosandbox/cuckoo/pull/2102/commits/3c39049127c48c2d0a98e7c6840a98b3445d5169 (Line 71 to 75) to allow mitmproxy to use the MITMPROXY_SSLKEYLOGFILE variable.

LetMeR00t commented 6 years ago

Sorry, I have to modify my meanings... You will need this PR on Cuckoo : https://github.com/cuckoosandbox/cuckoo/pull/2104/files

With the previous PR and this one, you should be able (respecting my previous comments) to be able to decipher the traffic using mitmproxy in transparent mode. On my way, it's working perfectly as expected. Don't hesitate if you need more information

LetMeR00t commented 5 years ago

Hi @jbremer, Keep updated this also for the fix issue on Cuckoo. If you think I misunderstanding something, tell me. Thank you

LetMeR00t commented 5 years ago

Duplicate : https://github.com/hatching/httpreplay/pull/25