Closed LetMeR00t closed 2 years ago
"All checks have failed" ?
@blshkv , if you check the details, you will see that pip2 is trying to recover mitmproxy 4.0.4 which doesn't exist in his reference... You have to install it using pip3
@jbremer @RicoVZ FYA
The error basically means that you have to drop python2 because mitmproxy no longer supports it. The patch is not complete
@blshkv , well I agree with you but once you installed mitmproxy using pip3 and then compile the source code for httpreplay using python2 (no issue as mitmproxy is not mandatory), you have no issue to use mitmproxy in 4.0.4 as all tests passed (and in the code, you can see that i'm using the mitmproxy 4.0.4 source code which is well interpreted in python2) And well, we can drop python2.7 if needed as the issue is mitmproxy itself in 0.18.2
Hi @blshkv, @jbremer , @RicoVZ Sorry for the last commits, I never used these tests before but it's very good when you understand how it works :) Now the patch is okay, only python3.6 in the tests, see if we need to keep Python2.7 ? Regards
Python2 will be out of support next year, so don't waste your time. You can create a new branch if you really want a smooth transition but i would not care
After reviewing my code again, I think I will need some more changes before you can review officially, I will do this asap. (Code is working but results of functions are returning bytes when they could return strings ...)
My repository was updated with your's today.
Fix issue for https://github.com/hatching/httpreplay/issues/19 and https://github.com/hatching/httpreplay/issues/23
Tested with both pytest versions, all tests passed (except one, but already in xfail state)