search

hatching / sflock

Sample staging & detonation utility to be used in combination with Cuckoo Sandbox.
82 stars 46 forks source link

Gzip Files requires native tooling #33

Open Rafiot opened 6 years ago

Rafiot commented 6 years ago

Is there a reason you're not using the gzip module to handle pure gzip file? You do that for .tar.gz, so it is confusing.

And if not, do you mind if I implement a pure python module to handle simple gzip files without requiring 7zip?

jbremer commented 6 years ago

Thanks, you're right! I think the most important aspect for me is keeping up performance; so preferably we have such pure Python implementation with opt-in 7z-based module, i.e., if 7z is installed it should opt for that method. This requires a bit more work, though.. feel free to PR as suggested in the meantime.

Rafiot commented 6 years ago

Sounds good, I'll push a PR ASAP

jbremer commented 6 years ago

What I suggested is basically what I described in #25, BTW.