hatching / vmcloak

Automated Virtual Machine Generation and Cloaking for Cuckoo Sandbox.
484 stars 121 forks source link

mkisofs/genisoimage argument incompatibility causing error on MacOS #204

Open CassieXx0215 opened 1 year ago

CassieXx0215 commented 1 year ago

When running vmcloak init --verbose --win7x64 win7x64base --iso-mount xxxxx --cpus 2 --ramsize 2048, I got the following error: ERROR:vmcloak.abstract:Error creating ISO file (err=255): Bad Option '-allow-limited-size' (error -1 BADFLAG).

Seems like -allow-limited-size is an argument for geniso on Linux, but not for mkisofs on MacOS. I solved it by pulling the source code, and removing this argument in /vmcloak/abstract.py on line 207.

If anyone runs into the same issue, this might be helpful. Or the developer could help solve this incompatibility in the code.

Cryss76 commented 1 year ago

I just run into the same problem, but I was using genisoimage on linux. Removing the Argument never the less fixed the issue.

I think the argument just got removed and it's not a MacOS and/or mkisofs problem

CassieXx0215 commented 1 year ago

I just run into the same problem, but I was using genisoimage on linux. Removing the Argument never the less fixed the issue.

I think the argument just got removed and it's not a MacOS and/or mkisofs problem

Ah thank you for the clarification and for making the pull request! Although I wonder whether this repo is still monitored by the developers, the latest commit was almost one year ago and cuckoo itself is also no longer maintained...

Cryss76 commented 1 year ago

Cuckoo 3 is now maintained by cert-ee (https://github.com/cert-ee/cuckoo3) and its last commit was a week ago so it seems somewhat alive. On the other side I all ready made a pull request for a minuscule change a month ago on this project and still haven't got an answer... so... yeah, it seems pretty dead, which is a shame because its a really useful tool...