search

hatching / vmcloak

Automated Virtual Machine Generation and Cloaking for Cuckoo Sandbox.
485 stars 121 forks source link

Missing "," in setup.py that causes wheel not to be built #214

Open Magerly666 opened 1 year ago

Magerly666 commented 1 year ago

setup.py: Line 47

install_requires=[
    "click",
    "jinja2",
    "pefile>=2019.4.18, <2019.5.0"
    "pyyaml>=5.1",
geeksailor commented 1 year ago

Devs, My update to this, my requires.txt in ~/venv/vmcloak/VMCloak.egg-info/requires.txt now shows:

pefile<2019.5.0pyyaml>=5.1,>=2019.4.18

I think someone accidentally cut and pasted the pyyaml in the middle of the pefile requirements. This seems to screwing it up worse and is confusing vmcloak that it needs a pip package with that name when I run the command. See error output below:

pkg_resources.DistributionNotFound: The 'pefile<2019.5.0pyyaml>=5.1,>=2019.4.18' distribution was not found and is required by VMCloak

Also I know this is built to work with Cuckoo3 among other programs, but Cuckoo3 now requires pefile>=2022.5.30, <2024.0.0. This causes a dependency conflict between VMCloak and Cuckoo3 preventing one or the other from working. At least inside a virtualenv. I haven't found a possible solution yet, but I figured if someone finds one that allows having both programs working could be useful for creating and editing images and snapshots and doing analysis.

EDIT: Possible solution: rather than running both in the same virtualenv, I'm running both doing an install using pipx to separate their dependencies. VMCloak appears to runs with no issues now so far. It makes them available globally rather than having to target that directory to get to vmcloak-qemubridge to start a bridge interface.

Cheers!