search

hatching / vmcloak

Automated Virtual Machine Generation and Cloaking for Cuckoo Sandbox.
483 stars 120 forks source link

Add vrde/vrdp capabilities to "vmcloak modify" #94

Open MarkusTeufelberger opened 7 years ago

MarkusTeufelberger commented 7 years ago

I patched in a m.vrde(3389, "") into https://github.com/jbremer/vmcloak/blob/master/vmcloak/main.py#L385 to be able to modify VMs remotely. It might be useful to others too or a nice feature to have in general, since headless mode is probably a relatively common use case.

If this functionality is popular, I would just add it with 2 more options to the modify command and submit a pull request.

jbremer commented 7 years ago

Hi. Yes, if you add an option to the command for specifying a VRDE port, that'd be great, and I'll merge it! Thanks :-)

razuz commented 7 years ago

👍 however what do you modify there ? maybe it makes more sense to automate that ? :) cause for cuckoo I'm not booting them up any more but possibly I've missed something that needs a restart after registry changes.

MarkusTeufelberger commented 7 years ago

Some setup routines/installers are easier if you do them manually and writing packages in yet another format (called "dependencies" here) might be overkill for some users. Also it would be just analogous to the "gui" mode, that is also available in vmcloak.

Last but not least, modifying via a GUI or remotely instead of writing a dependency means that you don't have to share your modification scripts according to GPL, which might be motivation for some?

razuz commented 7 years ago

absolutely :) some installers are also quite picky and might become even impossible to implement. Still - if there's some useful dependencies (complicated or not) you can always drop here :) Probably I can find some time to implement them.