search

hatchways / team-hulk

0 stars 0 forks source link

Web scrapper #53

Open AndresNeisa opened 3 years ago

AndresNeisa commented 3 years ago

The scraper.js file runs a script to fetch questions from leetcode, and store them into the database. The parameters of getQuestions allow the function to loop through a different range of questions, if a third parameter is sent with a value of true, the function will return the number of available questions in leetcode.
The html2markdown.js file converts the fetched HTML into markdown, which later on will be used to display the questions to the users, I wasn't so sure about the name of the file so any suggestions in that regard will be appreciated. This branch is based in another branch so I will wait to solve the merging conflicts until that branch gets merged.

dproc96 commented 3 years ago

It looks like there are some unrelated changes in here, is that because of the base branch being behind dev?

Additionally, can you add some instructions for testing this feature?

AndresNeisa commented 3 years ago

@sina-jamshidi I wasn't sure how to reply to your previous comments, so I will answer your suggestions here:

  1. The comment in the questions model has been removed.
  2. I changed the hardcoded value of the select input to a variable that gets the value from the option that contains "all" inside of it