search

hatchways / team-mint-oreo

1 stars 2 forks source link

Investigate Sidebar reloading on drawer open #101

Open Rocket-Fish opened 4 years ago

Rocket-Fish commented 4 years ago

it should switch seamlessly from open to close with the data already in it. Not sure why there is a split second of loading time.

replication steps: go into mobile view (viewport width < 500), open and close the sidebar

brianqian commented 4 years ago

Just to rehash our conversation, since the Sidebar component is being loaded in two places, they're not going to share state. We either have one sidebar component and control its UI state or if we want two, turn Sidebar into a display component and pass down data from a higher level.

Edit: Thinking about it I think it might make sense to pull our data in the dashboard component itself and pass down props to sidebar and chatframe. That way users' information in active chat windows can be shared with chat frame header, messages, and online status can be represented in sidebar