search

hatchways / team-scallops

1 stars 1 forks source link

Hotfix socket auth #121

Open dTechLife opened 2 years ago

dTechLife commented 2 years ago

What this PR does:

Screenshots / Videos (front-end only):

Screen Shot 2021-11-20 at 2 52 58 PM
dTechLife commented 2 years ago

LGTM! 👍🏽

Alternatively, why don't we consider opening the socket only once for each logged-in user

Hmm, I'll look into that in a separate ticket!

The issue here I am addressing is a case where multiple cookies are sent in the header of WebSockets connection, being non-inclusive of the token cookie. (cookies: "token=...; stripe_id=...;") This broke the method that was being used previously as stripe_id isn't a part of our token :)

It worked fine in a separate feature branch but once merged into the stripe feature branch it caused integration issues.