Closed hayderjebur closed 3 years ago
Looks very good overall, good job π― Left some minor comments, please have a look when you can πΌπΌ
One thing I was wondering, the
server/package-lock.json
seems to have changed but there aren't any backend changes π€ Could we exclude that change from the PR? (one way of doing this would be to checkout the file frommain/develop
).Lastly, thank you so much for formatting the PR nicely! I don't know about you but it looked soo much better to me! π
Regarding the package-lock.json, I wonder if would be a conflict between the develop branch and my PR, I would leave everything in develop branch and remove any things in package-lock.json from my branch! Is will that way solve the issue?
What this PR does (required):
Screenshots / Videos (front-end only):
Any information needed
to test this feature (required):
Any issues with the current functionality (optional):