Test add all auth - Githubissues

hatchways / team-scallops

1 stars 1 forks source link

Test add all auth #63

Closed navjot-chahal closed 3 years ago

navjot-chahal commented 3 years ago

What this PR does:

Adds mocha tests for /auth/register, /auth/login, /auth/user and /auth/logout routes.
Changes logout request type to "POST" from "GET" for both server and client side.

Screenshots / Videos:

CLI mocha test results:

Any information needed to test this feature:

Use npm run dev to start the test in the server folder.

closes #2

rajivtitus commented 3 years ago

@navjot-chahal why has this branch been merged without approval? :)

navjot-chahal commented 3 years ago

@rajivtitus There was a very minor change. Just the error code response is changed to 409 from 400. Is there any issue with the last commit?

Also, if this merge was a violation then I will make sure to wait for approval for a minor change as well before merging.

rajivtitus commented 3 years ago

@navjot-chahal There are no issues with the last commit, good work here :)

In the future please wait for approval from a Hatchways team member prior to merging PRs. We review PRs once again to make sure the requested feedback has been implemented or any new issues have been introduced.