Possibility to use Dates in X-Axis

hatemalimam / ChartistJSF

Highly Customizable Responsive Charts for JavaServer Faces.

https://chartistjsf-showcase.herokuapp.com

Apache License 2.0

39 stars 12 forks source link

Possibility to use Dates in X-Axis #21

Closed Holyphoenix closed 7 years ago

Holyphoenix commented 7 years ago

Hey, I just found this library yesterday and I am trying to determine if it will meet my needs. I need to be able to specify date values for my x-axis. So far, I am seeing that the x-axis is just hard set labels. Since my dates will vary wildly, and points won't always line up directly with the label, that won't work well. Is it hard to get dates or at least some sort of value instead of just a string value for the x-axis?

hatemalimam commented 7 years ago

The current structure accepts only strings as labels, but there's a solution (not yet integrated scheduled for 3.1) here https://github.com/hatemalimam/ChartistJSF/issues/15

Not sure if this is what are you looking for or would serve your purpose.

Holyphoenix commented 7 years ago

Yes, I believe that will work. Is there a way I can temporarily add this data while I wait for the new release? It appears the the Chartist version in ChartistJSF already supports it. I was looking at the widgetvar, but didn't see much in the way of accessing the chart data to modify it. It looks like I might just need to figure out how to build a chartist plugin temporarily that does this for me.

Holyphoenix commented 7 years ago

I looked at this more, it will support what I am after as long as you allow us to also change the x-axis type. I built a chart with just chartistjs in my code and not chartistjsf and it worked like a charm as soon as I set the type to type: Chartist.AutoScaleAxis. Will that capability be included in the next release as well?

hatemalimam commented 7 years ago

Well I can include that also in the next release, I guess since those are really small features, I can include them next week, or you can fork and send a merge request, I'de be happy to review and accept that. Anyway I guess next week I can include those and release 3.1. Cheers.

Holyphoenix commented 7 years ago

Awesome! It is much appreciated! I'll see about creating a pull request myself. Not sure I will have time before you can get to it next week.

hatemalimam commented 7 years ago

Well I guess I'm having some difficulties integrating the Axis types in the project due to some strange errors, I have opened an issue searching for some kind of a hint https://github.com/gionkunz/chartist-js/issues/1009 let's hope we get some answers as soon as possibile to move the development process further.

hatemalimam commented 7 years ago

Okay problem solved for specifying the axis types.

as mentioned here:

Few things to watch out for:

When specifying an axis type, the according value on the axis will be used as a label and also to compute the projection. You need to pass numeric values. In your example you can pass a Date object since it can be converted to a number (timestamp) and therefore does work with the projection math. Since you don't want to render timestamps as labels, you can use labelInterpolationFnc to format using Intl or Moment.js

Thad said the labels in the series has to be a numeric value..

As for the meta thing, I'll try to release ASAP.

Thank you.

Holyphoenix commented 7 years ago

Updated: NVM, I think I can make it work. Thanks for getting this done so quickly.

Holyphoenix commented 7 years ago

@hatemalimam Any word on the Meta piece? I looked over the code but wasn't sure the best approach to take in order to add it. I could take a guess and push some code. But if you figured out how you want to go about it and started implementing it I wouldn't want to waste effort.