hatemhosny / racing-bars

Bar chart race made easy πŸŽ‰
https://racing-bars.hatemhosny.dev/
MIT License
75 stars 4 forks source link

chore(deps): update packages #161

Closed AhmedElbohoty closed 3 months ago

AhmedElbohoty commented 3 months ago

Remove following packages:

netlify[bot] commented 3 months ago

Deploy Preview for racingbars ready!

Name Link
Latest commit 71a444a745679dcf522123fdbe1443fadb1f27d6
Latest deploy log https://app.netlify.com/sites/racingbars/deploys/66c575d2673596000842ef5f
Deploy Preview https://deploy-preview-161--racingbars.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

AhmedElbohoty commented 3 months ago

Hello @hatemhosny:

Do you still need the gh-pages?

hatemhosny commented 3 months ago

Thank you @AhmedElbohoty

Do you still need the gh-pages?

Although we are not directly using gh-pages, I still find it to be convenient for anybody who forks the repo to just run npm run deploy and get the website deployed without having to configure any cloud provider. I think we should just keep it for now.

Let's also keep tslib as it would be needed for some typescript features.

I have recently added @inquirer/prompts by mistake to dependencies. Would you kindly move it to devDependencies?

Thank you

hatemhosny commented 3 months ago

Have I missed merging this or was it not ready?

AhmedElbohoty commented 3 months ago

Have I missed merging this or was it not ready?

It’s not done yet. Upgrading Docusaurus has caused build issues, and I’m still looking into it.

AhmedElbohoty commented 3 months ago

Thank you @AhmedElbohoty

Do you still need the gh-pages?

Although we are not directly using gh-pages, I still find it to be convenient for anybody who forks the repo to just run npm run deploy and get the website deployed without having to configure any cloud provider. I think we should just keep it for now.

Let's also keep tslib as it would be needed for some typescript features.

I have recently added @inquirer/prompts by mistake to dependencies. Would you kindly move it to devDependencies?

Thank you

Okay. You can merge this pull request now.

hatemhosny commented 3 months ago

Okay. You can merge this pull request now.

That's great. Thank you.

It’s not done yet. Upgrading Docusaurus has caused build issues, and I’m still looking into it.

That's fine. Take your time. I expect so. I have swizzled some components to integrate the expanding code block below charts. So may be the new version has introduced some changes.

Thank you.