Closed AhmedElbohoty closed 3 months ago
Name | Link |
---|---|
Latest commit | 71a444a745679dcf522123fdbe1443fadb1f27d6 |
Latest deploy log | https://app.netlify.com/sites/racingbars/deploys/66c575d2673596000842ef5f |
Deploy Preview | https://deploy-preview-161--racingbars.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Hello @hatemhosny:
Do you still need the gh-pages?
Thank you @AhmedElbohoty
Do you still need the gh-pages?
Although we are not directly using gh-pages, I still find it to be convenient for anybody who forks the repo to just run npm run deploy
and get the website deployed without having to configure any cloud provider.
I think we should just keep it for now.
Let's also keep tslib as it would be needed for some typescript features.
I have recently added @inquirer/prompts by mistake to dependencies. Would you kindly move it to devDependencies?
Thank you
Have I missed merging this or was it not ready?
Have I missed merging this or was it not ready?
Itβs not done yet. Upgrading Docusaurus has caused build issues, and Iβm still looking into it.
Thank you @AhmedElbohoty
Do you still need the gh-pages?
Although we are not directly using gh-pages, I still find it to be convenient for anybody who forks the repo to just run
npm run deploy
and get the website deployed without having to configure any cloud provider. I think we should just keep it for now.Let's also keep tslib as it would be needed for some typescript features.
I have recently added @inquirer/prompts by mistake to dependencies. Would you kindly move it to devDependencies?
Thank you
Okay. You can merge this pull request now.
Okay. You can merge this pull request now.
That's great. Thank you.
Itβs not done yet. Upgrading Docusaurus has caused build issues, and Iβm still looking into it.
That's fine. Take your time. I expect so. I have swizzled some components to integrate the expanding code block below charts. So may be the new version has introduced some changes.
Thank you.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Update following packages:
d3
stylelint
stylelint-config-sass-guidelines
sass
prettier
postcss
postcss-cli
live-server
gh-pages
@types/jest
@types/live-server
@types/node
Remove following packages:
mkdirp
What is the current behavior? (You can also link to an open issue here) The same current behavior.
What is the new behavior (if this is a feature change)? No new behavior.