Proposal to Improve App Organization by Moving Reducers and Actions to the Store Directory

[AhmedElbohoty]

I'm submitting a ...

• Adjutment request

Summary

While documenting the app, I identified some changes that could enhance its organization. I recommend moving all reducers and actions into the store directory. When I initially explored src/lib, I found it a bit frustrating due to the many folders like container, data, and options, which only contains reducers and actions are outside store directory. Therefore, I suggest relocating these directories to the store and renaming them to container-slice, data-slice, and options-slice.

Since all the model files contain only types, I suggest renaming them to types.ts.

@hatemhosny

[hatemhosny]

Hi @AhmedElbohoty

Thank you for the suggestion.

I'm not sure the suggested directory structure simplifies the organiztion.

• the ticker directory also has actions, reducers and models. Should we also move it inside store? But then, most of the directories will be inside the store directory ending up with almost similar directory structure like now but nested inside the store directory.
• some of these directories contain logic that is not related to the store, like options/validate-options.ts and ticker/ticker.ts. This can be confusing.
• I wanted the store directory to be simple giving an overview of how everything works, and then the implementation of each slice stays near the related logic.
• Honestly, I find un-needed directory nesting to be more difficult to grasp than a simpler flat structure.

These are just personal preferences. Thank you for understanding.