search

hatepoint / phrases-hyperskill-tests

0 stars 1 forks source link

stage3 - solution that send notification before expected are being accepted #28

Open RedJocker opened 1 year ago

RedJocker commented 1 year ago

we should make assertions that notifications are not sent before expected

hatepoint commented 1 year ago

can you explain that a little more? i can't see the problem with that because i don't see how that can be harmful for the project

hatepoint commented 1 year ago

the only case i can come up with is that notifications are sent before the reminder time set/phrases added

RedJocker commented 1 year ago

a notification should only be sent on the time specified by the alarm (possibly with some system delay). We can't accept as valid for example a solution that sends notification without setting any kind of alarm mechanism. The tester Ruslan reported that on his stage3 report.

This requirement is also valid for stage4 and we should test that the next day notification happens not before the expected time