search

haterapps / fake-data

Fake Data - A form filler you won't hate
39 stars 2 forks source link

Update faker.js? #4

Closed latere-a-latere closed 3 years ago

latere-a-latere commented 3 years ago

Hi, I just noticed that the locale files of faker.js contain a lot more values than currently output by the addon.

I tried updating to the newest version myself by simply loading in a downloaded copy of faker.js as a background lib but this didn't seem to work that well. It'd generate values, but I wasn't able to set the locale.

Is it possible to have the addon updated to use the latest version?

haterapps commented 3 years ago

Hello,

Sure, let me look into this and I will get back with an update.

On Fri, Sep 11, 2020, 15:20 MarNicGit notifications@github.com wrote:

Hi, I just noticed that the locale files of faker.js contain a lot more values than currently output by the addon.

I tried updating to the newest version myself by simply loading in a downloaded copy of faker.js as a background lib but this didn't seem to work that well. It'd generate values, but I wasn't able to set the locale.

Is it possible to have the addon updated to use the latest version?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/haterapps/fake-data/issues/4, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKT34NZ7LJESPDJYZ6JG6BDSFII2JANCNFSM4RHLODNQ .

haterapps commented 3 years ago

Ok, so I updated the faker.js and moment.js libraries to their latest versions, and published them in version 2.18.5 of Fake Data.

For Firefox this version should already be available, but for Chrome and Edge might take a day or two.

Once you update, let me know if this fixes the issues that you had.

latere-a-latere commented 3 years ago

Yup, the strings that were missing are showing up! Thanks a lot for the quick update!