Closed Rbb666 closed 5 months ago
Thanks for your PR but it's more like an example configuration which should be added to rt-thread instead of tinyusb.
With your macro it only make things more complicate, more conditions need to check and only CDC+MSC is supported, what if someone simply wants 2*CDC ? tusb_descriptor.c/.h
should be application specifically written.
感谢您的 PR,但它更像是一个示例配置,应该添加到 rt-thread 而不是 tinyusb。
使用您的宏只会使事情变得更加复杂,需要检查更多条件并且仅支持 CDC+MSC,如果有人只是想要 2*CDC 怎么办? 应专门编写申请。
tusb_descriptor.c/.h
Hello, by doing this you can add the tinyusb repo as the rtthread package to the project. This form is similar to the LVGL project: https://github.com/lvgl/lvgl/tree/master/env_support/rt-thread
src/
is for tinyusb stack code, lots of pr's files are framework glue codes and does not belong to src/ folder. If rtthread needs these glue code to run, you can put it into instead.lib/
OK,I'll modify it.
Hello, by doing this you can add the tinyusb repo as the rtthread package to the project. This form is similar to the LVGL project: https://github.com/lvgl/lvgl/tree/master/env_support/rt-thread
Tinyusb has much more configurations than LVGL, it's impossible to cover every use case in a single tusb_config.h
and tusb_descriptor.c/.h
. That's why every example has its own configurations.
For example if you compare tusb_descriptor.c
from video_capture
and usb_msc
examples there is nearly nothing in common.
These files should be removed.
Hello, by doing this you can add the tinyusb repo as the rtthread package to the project. This form is similar to the LVGL project: https://github.com/lvgl/lvgl/tree/master/env_support/rt-thread
Tinyusb has much more configurations than LVGL, it's impossible to cover every use case in a single
tusb_config.h
andtusb_descriptor.c/.h
. That's why every example has its own configurations.For example if you compare
tusb_descriptor.c
fromvideo_capture
andusb_msc
examples there is nearly nothing in common.These files should be removed.
It has been modified, please take a look again.
我推送了 pre-commit 的修复程序。看起来不错,请注意,由于我还不知道如何使用 rtthread,我将无法维护代码,请提交 PR 以帮助使其保持最新状态。
No problem, I am an official member of rtthread and can help you maintain it.
…ojects.
Describe the PR Add rtthread script support to better integrate into rtthread projects. Tinyusb will be added to the rtthread project in the form of a software package.
Additional context If applicable, add any other context about the PR and/or screenshots here.