search

hathach / tinyusb

An open source cross-platform USB stack for embedded system
https://www.tinyusb.org
MIT License
5.06k stars 1.07k forks source link

Clarify SAM D5x/E5x support? #440

Closed jepler closed 4 years ago

jepler commented 4 years ago

Over in CircuitPython we are adding support for the SAM E54. Based on initial testing works properly with CFG_TUSB_MCU=OPT_MCU_SAMD51. If no special support is required, perhaps the configuration variable could be renamed (we are saying SAM_D5X_E5X in CircuitPython) or it could be noted in the documentation. However, it does not appear any change is required at this time.

hathach commented 4 years ago

Hi @jepler, I think it is best to have an additional option OPT_MCU_SAME5X Other vendors also use the same USB IP for different families. Normally it has a little different in configuration, included header, which is handled by dcd for example https://github.com/hathach/tinyusb/blob/master/src/portable/st/synopsys/dcd_synopsys.c#L35 .

In this case the asf4 does a great work of hardware abstraction, however, it is still beneficial to distinguish them for example, project that doesn't make use of asf4. I will make an PR to add the new MCU option.

hathach commented 4 years ago

OPT_MCU_SAME5X and OPT_MCU_SAMD51 are both existed although there is little difference thanks to asf4.