🔍 search bar functionality - Githubissues

hathitrust / firebird-common

Other

0 stars 0 forks source link

🔍 search bar functionality #12

Closed carylwyatt closed 1 year ago

carylwyatt commented 1 year ago

Search bar changes:

toggles open/closed from navbar (uses bootstrap collapse/toggle for mobile)
dropdown/select updates search hint
search help modal added (actual content TBD)
fixed minor style issues

Modal changes:

moved LoginFormModal global styles to scss/styles.scss
added scrollable prop (when passed to modal as in <Modal scrollable>, adds scroll bar to modal-body slot)
messed with z-index when open/closed... this fixed a bug where I couldn't click on elements behind the invisible modal, but now the modal has a glitch/blip in animation when closing 🤷‍♀️

Probably needs minor tweaks:

fix the modal z-index/animation problem for a smoother closing experience
search bar currently only has toggle ability, I didn't use Roger's search_state = default || toggle variable/prop which I assume might be necessary for WP subpages or Page Turner where the default state of the search bar is closed

netlify[bot] commented 1 year ago

Deploy Preview for hathitrust-firebird-common ready!

Name	Link
Latest commit	0b43ddcd5cffd308073a9fd85ef105962852af7e
Latest deploy log	https://app.netlify.com/sites/hathitrust-firebird-common/deploys/64385d986006fb0008a5df2a
Deploy Preview	https://deploy-preview-12--hathitrust-firebird-common.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.