search

hathitrust / firebird-common

Other
0 stars 0 forks source link

Add Chromatic #56

Closed carylwyatt closed 9 months ago

carylwyatt commented 9 months ago

Chromatic

I added Chromatic as a development dependency and a added a chromatic build script to package.json.

CI

To automatically build changes in Chromatic, I added our Chromatic project token to the repository secrets and added the workflow file suggested in the docs for github actions.

Storybook

I fixed the failing tests in storybook in order to get our storybook to build in Chromatic.

netlify[bot] commented 9 months ago

Deploy Preview for hathitrust-firebird-common ready!

Name Link
Latest commit b2eeee14b451d08aa2e1bf5640bf2be05f655faa
Latest deploy log https://app.netlify.com/sites/hathitrust-firebird-common/deploys/6573592b985f830008398f91
Deploy Preview https://deploy-preview-56--hathitrust-firebird-common.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

carylwyatt commented 9 months ago

I didn't look at what was failing in the tests before and so I can't really comment on whether the changes to make them pass make sense -- it might be more helpful to look at those together if you'd like feedback on them.

It was mostly changes that were made while I was out on leave that didn't get updated in their corresponding stories. I don't need feedback on those, thanks!