[DEV-1177] Feedback modal form fields and focus problems

hathitrust / firebird-common

Other

0 stars 0 forks source link

[DEV-1177] Feedback modal form fields and focus problems #75

Closed angelinanz closed 2 months ago

angelinanz commented 4 months ago

DEV-1177

[x] 1727230 identify input purpose missing for name and email
[x] 1727976 form validation error messages lack contrast
[x] 1727235 form validation error messages not being announced by screen reader
[x] 1727229 when modal is closed, focus isn't returned to trigger

carylwyatt commented 4 months ago

issue 1727976 is weird. I don't know if their tool had a glitch or something because the hex color code they gave for the error message is not what is in our code. 🤷‍♀️ our error message text already meets the 4.5:1 ratio. i added a comment to the issue in deque.