hathitrust / firebird-common

Other
0 stars 0 forks source link

DEV-1180: contrast colors and universal focus indicator #84

Closed carylwyatt closed 2 months ago

carylwyatt commented 3 months ago

The theme of this pull request is šŸŒˆ colors šŸŽØ . The problems addressed with these color updates are contrast between the background color and color of specific text areas, form element borders, striped tables, and focus indicators throughout the website and applications. Fixes issue #78

These fixes have been staged on dev-3:

Deque "checkpoints" we can consider complete:

Color contrast (regular text)

Cookie consent banner links

Issues 1727008 and 1727009

You might have to clear your cookies to see it on dev-3, but we changed the links from orange to black:

image

Striped tables

Fixes issue #76 The link color in striped tables on catalog records didn't have sufficient color contrast, so we darkened the links in those tables by one shade (primary-600 -> primary-700). Deque issues: 72 of the same issue, like this one: 1727028

image

Non-text contrast - active user interface components

Form element borders like checkboxes, radio selects, dropdown selects, text inputs all had improper contrast. We darkened the outline from the standard bootstrap rgba(51, 51, 51, .4) (basically a dark gray with the opacity turned down) to neutral-500.

(9 issues total, 2 marked as wont-do) 1727200, 1727428, 1727437, 1727485, 1727509, 1727692, 1728710

Non-text contrast - states of user interface components

Fixes issue #83

Our focus indicators were a mixed bag of blurred opacity borders (standard in bootstrap components). Because our primary color orange is already skirting the boundary of acceptable contrast, adding opacity to it made it worse. @giramesh designed a new universal focus indicator to work against all background colors. The new design is a solid 3px blue outline with a 6px white box shadow inside of it to ensure that any background will pass the contrast ratio for either the blue or the white. It's lovely!

Examples:

image image image image

Special case

Multi-select option in advanced search has a unique focus indicator because it's a unique use-case:

image image

Issues: (27 issues total, 1 marked wont-do): 1727129, 1727135, 1727185, 1727213, 1727217, 1727223, 1727228, 1727261, 1727309, 1727427, 1727443, 1727458, 1727473, 1727478, 1727508, 1727514, 1727515, 1727523, 1727547, 1727552, 1727821, 1727962, 1727972, 1727975, 1728319, 1728578

netlify[bot] commented 3 months ago

Deploy Preview for hathitrust-firebird-common ready!

Name Link
Latest commit 86a82a332e47418065d38465ddde319e4b5c73f6
Latest deploy log https://app.netlify.com/sites/hathitrust-firebird-common/deploys/66913068ff2b3d00089c9f9b
Deploy Preview https://deploy-preview-84--hathitrust-firebird-common.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.