netlify[bot]
commented
3 months ago Deploy Preview for hathitrust-firebird-common ready!
| Name | Link |
|---|---|
| Latest commit | 84ca5c09374c4b9950357bace5f2d7477c1b8833 |
| Latest deploy log | https://app.netlify.com/sites/hathitrust-firebird-common/deploys/667439a57c907f00082bd1be |
| Deploy Preview | https://deploy-preview-86--hathitrust-firebird-common.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
carylwyatt
giramesh
Fixes issue #77 and deque issues 1728595, 1727518, 1728277
Collection edit modal
This modal is a form, and the radio buttons under "Is this collection visible to others?" weren't accessible due to a missing legend/fieldset combo. I changed the paragraph to a legend and surrounded the radio button field with the fieldset tags.
To test: On dev-3 (vpn required), test either ls search results or any collection. Check the checkbox next to an item, and select "Add" from the toolbar. You should get a modal! Test this with a screen reader: when you tab to the radio buttons, it should now announce the radio button that is selected and the question in the legend ("Is this collection visible to others?").
Collections toolbar
The collection toolbar has a "Select all" button that uses a checkbox/checkmark icon instead of an actual checkbox 🙃 in order to indicate to screen readers whether this button is "pressed" or "unpressed" (since it's not a checkbox with the built-in "checked" attribute), we needed to add
aria-pressedand indicate whether that's true/false.To test: open any collection on dev-3 (like this one), inspect the "Select all button" in the dev tools to see the new
aria-pressedattribute. If the button has an empty checkbox icon, the attribute should be "false." Press the button, see the icon turn to a checked box, andaria-pressedshould betrue.