DEV-969 merge hathifiles-database, hathifiles-history, hathifiles

moseshll commented 4 months ago

Merge files from hathifiles_history
- Adopt anonymous positional arguments (*) for Ruby 3.2
Use hathifile_database gem.
Remove wait-for and fetch using wget (will be superseded by healthcheck later)
Remove lib/hathifile_record.rb which seems to do nothing except screw up tests when included.
Rename ci.yml to tests.yml
Remove local bin/wait-for

Currently wait-for doesn't seem to be findable by the GitHub action, that's why test is failing.

aelkiss commented 4 months ago

Yeah, let's get rid of wait-for and set up a proper health check as well (hopefully rinse & repeat from https://github.com/hathitrust/oai_solr/pull/27)

coveralls commented 4 months ago

coverage: 99.791% (+2.3%) from 97.45% when pulling e77c55f8ca4b5c2e2bc49f83ec40078a81c7c82b on DEV-969_merge_hathifiles into d431a15f6a3234cea3fa88b31814a32824527add on main.

moseshll commented 4 months ago

Pushed the solution to the wait-for problem since I walked face-first into it. Have the healthcheck for mariadb working okay, pushgateway is going to take a little more work (it has a /healthy endpoint but still need to figure out how to invoke it).

hathitrust / hathifiles

DEV-969 merge hathifiles-database, hathifiles-history, hathifiles #38