TTO-216 Hathifiles permissions are incorrect

hathitrust / hathifiles

Generation of Hathfiles

0 stars 0 forks source link

TTO-216 Hathifiles permissions are incorrect #46

Closed moseshll closed 2 months ago

moseshll commented 2 months ago

Fixes a bug introduced when we went with Tempfile.create to accumulate the output hathifile, vs just creating it in situ.
Tempfiles are 0600 by default which is wrong for our purposes, we want them at 644 because the owner is currently tomcatrhel5 and 0600 locks everyone out.
Reviewer: a brief inspection and test run should be sufficient.

coveralls commented 2 months ago

coverage: 100.0%. remained the same when pulling 69d921aa98aaebf7bd237ba79c31ff99a821acb1 on TTO-216_fix_incorrect_permissions into 4753d62e25b92e0d61278e4b26e2ead8609e5241 on main.

aelkiss commented 2 months ago

@mwarin was trying to run the tests locally, but ran into some issues.

moseshll commented 2 months ago

We're willing to lay reviewer's issues at the feet of Docker. It seems pretty clear that the tests are well behaved elsewhere.