Add second monitor via xrandr cause segfault

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Start Xserver with one monitor
2. Connect second monitor
3. Run 'xrandr --output VGA1 --auto --left-of LVDS1'

What is the expected result? What do you see instead?

Expected that system use both monitor.
Getting restart Xserver and record in log:
<timestamp> <hostname> kernel: wmii[5093]: segfault at 0 ip 00000000004179f1 sp 
00007fffa3353590 error 4 in wmii[400000+2e000]

What version of the product are you using (wmii -v)? On what operating
system (uname -a)?

wmii-3.9.2, ?2010 Kris Maglione

Linux <hostname> 2.6.37-gentoo #4 SMP Fri Jan 21 05:50:08 CET 2011 x86_64 
Intel(R) Core(TM)2 Duo CPU T9550 @ 2.66GHz GenuineIntel GNU/Linux

X.Org X Server 1.9.4
Release Date: 2011-02-04
X Protocol Version 11, Revision 0

Please provide any additional information below.

Original issue reported on code.google.com by mail....@gmail.com on 8 Mar 2011 at 5:38

[GoogleCodeExporter]

I suffer the same bug.

$ wmii -v
wmii-3.9.2, ©2010 Kris Maglione
$ uname -a
Linux <hostname> 2.6.35-23-generic #41-Ubuntu SMP Wed Nov 24 10:18:49 UTC 2010 
i686 GNU/Linux
$ Xorg -version

X.Org X Server 1.9.0
Release Date: 2010-08-20
X Protocol Version 11, Revision 0
Build Operating System: Linux 2.6.24-27-server i686 Ubuntu

Original comment by chm...@gmail.com on 9 Mar 2011 at 10:57

[GoogleCodeExporter]

This bug does not occur for me:

$ wmii -v
wmii-hg2785+, ©2010 Kris Maglione

$ xrandr --output HDMI1 --auto --left-of LVDS1

Please try with wmii @ hg tip (not 3.9.2).

Original comment by sun...@gmail.com on 14 Mar 2011 at 8:16

[GoogleCodeExporter]

Thanks, sun... I've upgraded and now I don't seem to have the problem. At least 
not at the moment.

Previosly, changing the monitor didn't always fail, only most of the times :).

I'll keep you informed if it works without trouble for a week.

Original comment by chm...@gmail.com on 15 Mar 2011 at 9:00

[GoogleCodeExporter]

The bug re-appeared today again when I changed from the external monitor to the 
laptop's.

$ wmii -v
wmii-hg2785, ©2010 Kris Maglione
$ uname -a
Linux enki 2.6.35-27-generic #48-Ubuntu SMP Tue Feb 22 20:25:29 UTC 2011 i686 
GNU/Linux
$ Xorg -version

X.Org X Server 1.9.0
Release Date: 2010-08-20
X Protocol Version 11, Revision 0
Build Operating System: Linux 2.6.24-28-server i686 Ubuntu

Latest segfaults (first with wmii-3.9.2, later with wmii-hg2785).

$ sudo grep wmii /var/log/kern.log
Mar 14 14:14:53 <host> kernel: [61184.248124] wmii[3391]: segfault at 0 ip 
0805ddb0 sp bf8a6850 error 4 in wmii[8048000+24000]
Mar 18 13:58:40 <host> kernel: [11398.884225] wmii[3474]: segfault at 0 ip 
0805ddb0 sp bff317a0 error 4 in wmii[8048000+24000]
Mar 18 14:32:30 <host> kernel: [13429.073088] wmii[12322]: segfault at 0 ip 
0805ddb0 sp bfe2ab80 error 4 in wmii[8048000+24000]

Original comment by chm...@gmail.com on 18 Mar 2011 at 6:42

[GoogleCodeExporter]

Hello.

I tried the patch from the upstream revision claiming to solve the issue #153 
but it didn't help me with 3.9.2, so some debugging resulted in the patch 
attached.

Original comment by Andrew.Shadoura on 31 May 2011 at 1:47

Attachments:

• 05-fix-xrandr-crash.patch

[GoogleCodeExporter]

Andrew, wmii 3.9.2 is an ancient release and is unsupported IMHO.

Please build wmii from its source repository and see if the bug still occurs.

Thanks.

Original comment by sun...@gmail.com on 31 May 2011 at 9:18

[GoogleCodeExporter]

Even if it doesn't occur, the code in fns.h is vulnerable to NULLs appearing in 
some uncomfortable places, so additional checks as in my patch may help to keep 
wmii from crashing.

Original comment by Andrew.Shadoura on 31 May 2011 at 9:26

[GoogleCodeExporter]

Good point.  If you would kindly rebase your patch against hg tip (HEAD of 
wmii's source repository), it would make it much easier for Kris to apply your 
patch when he returns from his sabbatical.

Original comment by sun...@gmail.com on 31 May 2011 at 10:31

[GoogleCodeExporter]

Here it is.

Original comment by Andrew.Shadoura on 1 Jun 2011 at 5:24

Attachments:

• fns.diff

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

This issue was closed by revision 5be87959705e.

Original comment by maglion...@gmail.com on 19 Sep 2011 at 8:15

• Changed state: Fixed