search

hatnote / monumental-wlm

BSD 3-Clause "New" or "Revised" License
3 stars 6 forks source link

WLM template added for GB entries has an invalid country code #55

Open Suntooth opened 2 months ago

Suntooth commented 2 months ago

When uploading an image for the UK version of WLM2024, the country code used is just the invalid "gb", rather than the more specific "gb-eng" for England (not sure what the codes are for Wales, Scotland, or NI), which causes a No or incorrect country code indicated in the {{Wiki Loves Monuments 2024}} template error and adds the file to Category:Images from Wiki Loves Monuments 2024 in an unknown country.

mahmoud commented 2 months ago

Hey @Suntooth yeah this is a known issue caused by some divergence between the organizing approach when the tool was written and the current organization of WLM.

I'm not sure if it's fixable, per se, but if it was, it would first involve fixing this data structure here: https://github.com/hatnote/monumental-wlm/blob/a5ca4802dcb28574b6344096f21f75670f669a92/src/services/campaigns.service.js#L237-L241

I believe this plan for the last couple years has been to transition to a tool used by Italy, and that should take effect for next year's competition. I've been talking to Richard Nevell on the UK side and Rebecca O'Neill on the Ireland side. Hope this helps.