search

hatoo / egglog-language-server

A language server and VScode extension for egglog
MIT License
10 stars 1 forks source link

Duplication with egglog vscode extension #4

Open oflatt opened 12 months ago

oflatt commented 12 months ago

Hi! It looks like this extension is more fully featured than the one in the egglog repo: https://github.com/egraphs-good/egglog/tree/main/vscode/eggsmol-1.0.0

Would you be interested in merging it into egglog? Or perhaps we should make this the official one, and move it to egraphs-good/egglog-language-server?

hatoo commented 12 months ago

Yes! I have no preference about merging it into egglog or making this the official one. Either is OK!

Perhaps we need to also consider about https://github.com/hatoo/tree-sitter-egglog egglog-language-server depends on it.

oflatt commented 11 months ago

I think that adding both tree-sitter-egglog and this repo to the egglog repository would be my vote

oflatt commented 11 months ago

That being said, we are struggling to maintain egglog right now- there are lots of features we want and clean-ups to do. If you merge into egglog, it would be great if you maintain it in the future when we change language features!

hatoo commented 11 months ago

I think that adding both tree-sitter-egglog and this repo to the egglog repository would be my vote

Looks good.

That being said, we are struggling to maintain egglog right now- there are lots of features we want and clean-ups to do. If you merge into egglog, it would be great if you maintain it in the future when we change language features!

Yeah, I'm happy to do that!

The main reason I wasn't quite active for a month at egglog-language-server is just the lack of feedback. I think it will be better after merging to main repository.

So, how do we proceed with merging? May I create PR about this?

oflatt commented 11 months ago

That's great! Yes, I think a PR would be great. I'll encourage people to start using it and give feedback on your PR!