search

hatoo / oha

Ohayou(おはよう), HTTP load generator, inspired by rakyll/hey with tui animation.
MIT License
5.62k stars 138 forks source link

About version scheme #430

Closed chenrui333 closed 7 months ago

chenrui333 commented 7 months ago

👋 looks like there is a new version of 1.4.0-pgo, but the --version output is still 1.4.0, maybe it is better to just create a new patch version as 1.4.1 (which also matches with SemVer scheme). Thanks!

relates to https://github.com/Homebrew/homebrew-core/pull/166328

hatoo commented 7 months ago

Thanks,

I've published a 1.4.0-pgo tag because I've just updated a CI that doesn't contain app code changes. It feels odd to me to publish 1.4.1 with such a situation... But sure, I'll publish 1.4.1. Please wait a few minutes.

chenrui333 commented 7 months ago

it is fine, the better versioning scheme is more easier for downstream consumption.

Thanks for pushing a new release.

chenrui333 commented 7 months ago

FYI, your crate did not get updated, https://crates.io/crates/oha

chenrui333 commented 7 months ago

The new release works for me, closing the issue now. Thanks again!