hats-finance / Accumulated-finance-0x75278bcc0fa7c9e3af98654bce195eaf3bb6a784

0 stars 0 forks source link

Deposit events in NativeMinter and ERC20Minter do not emit minted shares and Refund events do not emit the redeemAmount #22

Open hats-bug-reporter[bot] opened 2 months ago

hats-bug-reporter[bot] commented 2 months ago

Github username: -- Twitter username: -- Submission hash (on-chain): 0xf2b73f8608de8dd5946ba2aecf525370808166051558a9f69a2e4bd27654f50e Severity: low

Description: Description\ Deposit events in NativeMinter and ERC20Minter do not emit minted shares.

Redeem events do not emit the redeemed amount.

event Deposit(address indexed caller, address indexed receiver, uint256 amount);
...
emit Deposit(address(msg.sender), receiver, amount);
event Redeem(address indexed caller, address indexed receiver, uint256 amount);
...
emit Redeem(address(msg.sender), receiver, amount);

Attack Scenario\ This can be an issue with integrations or indexing the events.

Recommendation Consider adding the minted shares and redeemed shares to Deposit and Redeem events.

ilzheev commented 2 months ago

Events are informational, they are not used in any protocol infra.