hats-finance / Accumulated-finance-0x75278bcc0fa7c9e3af98654bce195eaf3bb6a784

0 stars 0 forks source link

Inconsistent Naming Convention Suffix #55

Open hats-bug-reporter[bot] opened 2 months ago

hats-bug-reporter[bot] commented 2 months ago

Github username: -- Twitter username: -- Submission hash (on-chain): 0x57cb158c1279839bb6482592fbef7c406feb879fde803ebc9e0f76231b6b53b2 Severity: low

Description: Description\

The contract InflationaryCircles implements the name() function, where -ERC20s is used to represent "ERC20 static." The expected behavior, as described in the comments, is to use a consistent suffix that conveys the correct context to the users and other contracts interacting with the system. However, the actual implementation introduces inconsistency in the naming convention, which can lead to confusion or misinterpretation. This inconsistency could create issues in both the user experience and interactions with external systems.

Attachments

  1. Proof of Concept (PoC)

in the lift/InflationaryCircles.sol:

function name() external view returns (string memory) {
@>      // append suffix for "ERC20 static" to the ERC20 name
@>      return string(abi.encodePacked(nameRegistry.name(avatar), "-ERC20s"));
    }
  1. Revised Code

Either update the comment or fix the suffix added to fix this inconsistency.

0xRizwan commented 2 months ago

Wrong submission. This is AccumulatedFi contest.