The contract InflationaryCircles implements the name() function, where -ERC20s is used to represent "ERC20 static." The expected behavior, as described in the comments, is to use a consistent suffix that conveys the correct context to the users and other contracts interacting with the system. However, the actual implementation introduces inconsistency in the naming convention, which can lead to confusion or misinterpretation. This inconsistency could create issues in both the user experience and interactions with external systems.
Attachments
Proof of Concept (PoC)
in the lift/InflationaryCircles.sol:
function name() external view returns (string memory) {
@> // append suffix for "ERC20 static" to the ERC20 name
@> return string(abi.encodePacked(nameRegistry.name(avatar), "-ERC20s"));
}
Revised Code
Either update the comment or fix the suffix added to fix this inconsistency.
Github username: -- Twitter username: -- Submission hash (on-chain): 0x57cb158c1279839bb6482592fbef7c406feb879fde803ebc9e0f76231b6b53b2 Severity: low
Description: Description\
The contract
InflationaryCircles
implements the name() function, where-ERC20s
is used to represent "ERC20 static." The expected behavior, as described in the comments, is to use a consistent suffix that conveys the correct context to the users and other contracts interacting with the system. However, the actual implementation introduces inconsistency in the naming convention, which can lead to confusion or misinterpretation. This inconsistency could create issues in both the user experience and interactions with external systems.Attachments
in the lift/InflationaryCircles.sol:
Either update the comment or fix the suffix added to fix this inconsistency.