search

hats-finance / AlephZeroAMM-0x0d88a9ece90994ecb3ba704730819d71c139f60f

Apache License 2.0
1 stars 0 forks source link

Missing PSP22Metadata Implementation for the Pair Contract. #41

Open hats-bug-reporter[bot] opened 9 months ago

hats-bug-reporter[bot] commented 9 months ago

Github username: -- Twitter username: 0xmahdirostami Submission hash (on-chain): 0xc263268185c3119c8950494cf56570f1fca9b033a52fa7e2ccc8dc2002c04ecf Severity: minor

Description: Description

The pair contract lacks metadata implementation. In the original Uniswap, there is a fixed symbol and name for the metadata, but the current Rust implementation uses default values for metadata.

Impact

The absence of proper metadata may affect the clarity and interoperability of the pair contract with external systems.

Proof of Concept

Uniswap Solidity Version: Link to Code Rust Version: Link to Code

Recommended Mitigation

Implement logic for pair metadata by setting appropriate values for symbol and name in the Pair contract. This will enhance the contract's compatibility and interoperability with external systems.

deuszx commented 9 months ago

Thank you for the submission. After carefully reviewing it we've concluded to accept it as VALID and submitted severity level - MINOR.