Wrong implementation of constructor.

[hats-bug-reporter[bot]]

Github username: -- Twitter username: @recursiveAudit Submission hash (on-chain): 0xdc4c563b13ebcebd7a558df1c5dd3a4917e84ab4e51d486623be04def381667c Severity: low

Description: Description\ In EIP712:constructor before checking for zero address check they are assigning it's value to external_signer

Attack Scenario\ just a bad practice. consider first checking and then assigning.

Attachments

1. Proof of Concept (PoC) File

constructor(string memory domainName, string memory version, address signer) EIP712(domainName, version) {
        external_signer = signer;
        require(signer != address(0), "ZERO_SIGNER");
    }

2. Revised Code File (Optional)

constructor(string memory domainName, string memory version, address signer) EIP712(domainName, version) {
-      external_signer = signer;
-       require(signer != address(0), "ZERO_SIGNER");
+       require(signer != address(0), "ZERO_SIGNER");
+      external_signer = signer;
    }

[alex-sumner]

Whilst stylistically a reasonable point, this is not a bug. Reordering the two lines will make no difference to the outcome, which in both cases is that the transaction reverts.

[bahurum]

Since there is no impact at all, I would say this is informational and not low severity