hats-finance / Catalyst-Exchange-0x3026c1ea29bf1280f99b41934b2cb65d053c9db4

Other
1 stars 2 forks source link

Missing checks for address(0) when assigning values to address state variables #14

Open hats-bug-reporter[bot] opened 8 months ago

hats-bug-reporter[bot] commented 8 months ago

Github username: @saidqayoumsadat Twitter username: saqsadat143 Submission hash (on-chain): 0x0e9b46da44b881bc0041ddc79eb1fcdf9f371d37ad7719099de2a2136d413c5b Severity: low

Description:

  1. Proof of Concept (PoC) File
file: /CatalystFactory.sol

33        _governanceFeeDestination = defaultOwner;

https://github.com/catalystdao/catalyst/blob/27b4d0a2bca177aff00def8cd745623bfbf7cb6b/evm/src/CatalystFactory.sol#L33C1-L33C50

file:  /CatalystVaultCommon.sol

129        FACTORY = factory_;
130        MATHLIB = mathlib;

https://github.com/catalystdao/catalyst/blob/27b4d0a2bca177aff00def8cd745623bfbf7cb6b/evm/src/CatalystVaultCommon.sol#L129C1-L130C27

reednaa commented 8 months ago

Dublicate of previous issue