search

hats-finance / Catalyst-Exchange-0x3026c1ea29bf1280f99b41934b2cb65d053c9db4

Other
1 stars 2 forks source link

Missing checks for address(0x0) in the constructor/initializer #22

Open hats-bug-reporter[bot] opened 6 months ago

hats-bug-reporter[bot] commented 6 months ago

Github username: @saidqayoumsadat Twitter username: saqsadat143 Submission hash (on-chain): 0xf09d35d886a93ada73fc82c10a829343801ddc4c41cb394e68c402996e85bfa8 Severity: low

Description:

  1. Proof of Concept (PoC) File
file: /src/CatalystFactory.sol

33        _governanceFeeDestination = defaultOwner;

https://github.com/catalystdao/catalyst/blob/27b4d0a2bca177aff00def8cd745623bfbf7cb6b/evm/src/CatalystFactory.sol#L33C1-L33C50

file: /src/CatalystVaultCommon.sol

195        _chainInterface = chainInterface;
196        _setupMaster = setupMaster;

203        name = name_;
204        symbol = symbol_;

https://github.com/catalystdao/catalyst/blob/27b4d0a2bca177aff00def8cd745623bfbf7cb6b/evm/src/CatalystVaultCommon.sol#L195C1-L204C26

reednaa commented 6 months ago

Dublicate.