search

hats-finance / Catalyst-Exchange-0x3026c1ea29bf1280f99b41934b2cb65d053c9db4

Other
1 stars 3 forks source link

Governance fee is not sent to timelock #52

Open hats-bug-reporter[bot] opened 5 months ago

hats-bug-reporter[bot] commented 5 months ago

Github username: -- Twitter username: 97Sabit Submission hash (on-chain): 0x680d86d63bc6236a8b5534603addf657bee8112919ab8d381c84f14f9aa15211 Severity: high

Description: Description\ The goverenance fee is not sent to the timelock but straight to the address set as the governanceFeeeDestination by the vault owner.

The governance fee is sent in this line: https://github.com/catalystdao/catalyst/blob/27b4d0a2bca177aff00def8cd745623bfbf7cb6b/evm/src/CatalystVaultCommon.sol#L384

It is sent to the governanceFeeDestination address set in the factory:

https://github.com/catalystdao/catalyst/blob/27b4d0a2bca177aff00def8cd745623bfbf7cb6b/evm/src/CatalystVaultCommon.sol#L142

And it goes to the address set here: https://github.com/catalystdao/catalyst/blob/27b4d0a2bca177aff00def8cd745623bfbf7cb6b/evm/src/CatalystFactory.sol#L44-L48

  1. Revised Code File (Optional)
reednaa commented 5 months ago

Intended.