hats-finance / Convergence-Finance---IBO-0x0e410e7af8e70fc5bffcdbfbdf1673ee7b3d0777

IBO, Vesting & Bond mecanism repo prepared for Hat finance audit competition
0 stars 0 forks source link

Release after begin of schedule sometimes doesn't change balances within the acceptable range #77

Open hats-bug-reporter[bot] opened 1 year ago

hats-bug-reporter[bot] commented 1 year ago

Github username: @marcobesier Submission hash (on-chain): 0x23eedf39e1779fcc57404631bd5653959d983a3615f5ec69cae45793bb8a0db9 Severity: medium

Description: Description\ When running the test suite, the "WL_S (7) release after begin of schedule should change balances" test will occasionally throw an assertion error.

Attack Scenario\ Run the above test often enough, and it will eventually fail.

Attachments

  1. Proof of Concept (PoC) File The current codebase - unchanged.

  2. Revised Code File (Optional)

marcobesier commented 1 year ago

For the sake of completeness, here's the specific error that's printed to the console:

  155 passing (2m)
  1 failing

  1) Vesting Cvg / Release tests
       WL_S (7)  release after begin of schedule should change balances:
     AssertionError: expected 300001018399999999999 to be close to 299999999999999999999 +/- 1000000000000000
      at Context.<anonymous> (test/mocked-assets/PresaleVesting/presale-vesting-test.js:193:58)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
walk-on-me commented 1 year ago

Hello, Thanks a lot for your attention.

This issue is an environment issue on your side I think As our tests are time dependant, it's really possible that your machine is quicker or slower than ours and so triggers the delta

We have so to consider this issue as Invalid